Since those who want impeachment seems to be a one party affair, short term, Trump may benefit from it. The one party affair, you can see that 71% of Democrats want Trump impeached and removed from office, 10% of Democrats do not. Republicans on the other hand show 81% against with only 9% favoring impeachment and removal. You can't get more partisan than that. Independents, the non-affiliated, less to non-partisan, probably most not in either the pro or anti Trump camps. 31% favor impeachment and removal, 41% are opposed with 28% not sure or don't give an owl's hoot one way or the other. Question 11.
https://d25d2506sfb94s.cloudfront.net/cumulus_uploads/document/dl1xj5lsd9/econTabReport.pdf
Who does impeachment favor, I look back at Bill Clinton's impeachment. His approval rating among independents, only independents rose from 51% to 70% with his overall approval rating going up from 59% to 65% during the impeachment process and trial. Most Americans didn't want Bill to go anywhere. His impeachment was also a one party affair which backfired on the Republicans. That was the short term effects, Trump would probably gain in the short term in that independents don't like a one party affair as it stinks of a very partisan political vendetta against a sitting president.
Long term, 3 months after the trial ended, Bill Clinton dropped back to a 50% approval among independents. What he gained during impeachment, he lost once it was over. I figure the same would happen to Trump. But if Trump was impeached, it might end the political vindictiveness against him which might help come reelection time or not. It could lead to a political campaign against the Democrats that they tried to railroad a legitimate president out of office. Sort of a silent coup. I think if impeachment happens before the beginning of next year and all the presidential campaigns, it would be a wash. A waste of time, energy and money as the senate would never gain the 2/3rds majority needed to remove Trump. Ala Bill Clinton in his 1999 senate trial.