He broke the law and has to serve jail time, but his long-term detention without trial is against habeas corpus in the Constitution and it's unfortunate that some people can't see through their hate and look at the situation for what it is. But... we live in degenerate times and people have lost the ability to defend the rights of their political enemies, and thus they too will gradually suffer the same fate.
Manning revealed crimes against humanity that if any other government were committing, the White House would be the first to speak out against. Fact is, he embarrassed us by showing we are not a goody-two-shoes nation that is in the Middle East for higher purposes. Some of our soldiers get off on killing innocent people and there is no oversight to prevent it. It proves that some of the ground level testimony coming out of the region from affected townships and families is true.
As for what he revealed about troop deployments... so what? We have been fighting against guerrillas in Afghanistan and Iraq and they already know where to find us.
As far as I'm concerned Manning did us a service by exposing corruption, something that journalism would have already been doing if our government wasn't actively censuring them in the war zone. But they're not because they don't want another Vietnam on their hands.